search

mhfs / devise-async

Send Devise's emails in background. Supports Resque, Sidekiq, Delayed::Job and QueueClassic.
MIT License
575 stars 110 forks source link

Devise support for ActiveJob. Is this gem deprecated? #108

Open coorasse opened 1 year ago

coorasse commented 1 year ago

Looking at Devise documentation they support integration with ActiveJob. In my eyes, this makes this library deprecated. Shall we write it in the README?

dan-jensen commented 9 months ago

I agree, this gem is probably deprecated.

This gem is still useful for Rails apps that don't use ActiveJob (either they haven't been upgraded to 4.2+ or ActiveJob is deliberately not used), but that's relatively few apps.

I think the only reason this gem would not be considered deprecated is if it were modified to add the ActiveJob integration from the Devise documentation. And there could be some value in that, because then there's no need for "overriding the send_devise_notification method in your model". Model code stays cleaner (and probably better-tested). This gem already follows the same approach, so it shouldn't be a major restructure. But is it worth the effort?