search

mhfs / devise-async

Send Devise's emails in background. Supports Resque, Sidekiq, Delayed::Job and QueueClassic.
MIT License
575 stars 110 forks source link

use deliver_now if possible in preparation for Rails 5 #60

Closed barelyknown closed 9 years ago

barelyknown commented 10 years ago

This fixed https://github.com/mhfs/devise-async/issues/59.

barelyknown commented 9 years ago

Ping @mhfs.

futhr commented 9 years ago

+1

rwojsznis commented 9 years ago

Side note: as rails 4.2 ships with activejob you can simply do this to achieve what devise-async is doing. Sooo... this kinda makes this gem obsolete (more or less, depending on your needs obviously).

marcgg commented 9 years ago

This seems interesting, is it going to be merged ?

futhr commented 9 years ago

@marcgg as @emq and Devise information is pointing out its a tiny 3 line method (+ tests) that's kind of superseeds this gem. And it works very well.

baschtl commented 9 years ago

@barelyknown I guess this is still somewhat useful. Could you fix the merge conflicts? Then we would be able to merge it.

baschtl commented 9 years ago

@barelyknown Thanks!