search

mhgbrown / cached_resource

Caching for ActiveResource
MIT License
80 stars 28 forks source link

store objects as json in cache so we don't get undefined class/module… #40

Closed tindron closed 6 years ago

tindron commented 6 years ago

… when there is a relation in the object

I rebased #22 on the latest master so it's ready to be merged. (fix for #6 and #33)

Daniel-ltw commented 6 years ago

@tindron have you tried this code changes any where else?

tindron commented 6 years ago

Just on the service where I was experiencing the issue. Before this change I would get uninitialized constant errors after starting rails when retrieving cached resources with nested json. After, I am successfully able to retrieve them immediately after starting rails.

Daniel-ltw commented 6 years ago

That does sounds good to me. Will merge this in now.

mhgbrown commented 6 years ago

@Daniel-ltw looks like we need a version bump and release?

Daniel-ltw commented 6 years ago

Yup.

Based on the code, things look good.

mhgbrown commented 6 years ago

Great, I'll do that tomorrow (CEST)

On Wed, Aug 8, 2018, 22:17 Daniel Leong notifications@github.com wrote:

Yup.

Based on the code, things look good.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/mhgbrown/cached_resource/pull/40#issuecomment-411538137, or mute the thread https://github.com/notifications/unsubscribe-auth/AAL2QAoOmH7uCUKcNAbUR8fmpT4kBhYTks5uO0dsgaJpZM4Vy5JB .

-- Morgan

mhgbrown commented 6 years ago

released in https://github.com/mhgbrown/cached_resource/tree/v5.1.0