search

mhgbrown / cached_resource

Caching for ActiveResource
MIT License
80 stars 28 forks source link

[ISSUE-56] Do not cache when cache is disable #58

Closed jlurena closed 7 months ago

jlurena commented 7 months ago

Disable cache completely, do not use it when it is disabled.

Resolves https://github.com/mhgbrown/cached_resource/issues/56

Spec run:

2024-01-09_17-21-12
jlurena commented 7 months ago

Looks great, thank you! Feel free to merge whenever. I don't have an automated deploy setup yet, so I'll have to do it manually after you merge.

Separately, trying to figure out how to run the "Test" workflow on this branch, but I'm not seeing any "Workflow(s) awaiting approval" as mentioned here. Any ideas?

I'm not sure honestly. Maybe workflow wasn't triggered? Also I don't have permissions to merge. Neither this one nor the other pull request I created.

Maybe permissions need updating? https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#defining-access-for-the-github_token-scopes

jlurena commented 7 months ago

Closing in favor of https://github.com/mhgbrown/cached_resource/pull/59