Closed jlurena closed 7 months ago
Great. Any glaring/obvious incompatibilities with ActiveResource?
Not that I noticed no 🙂. We should be fine to just merge this as it includes both ISSUE-56 and ISSUE-57. How is it merged and then uploaded to rubygems?
Is version change automatic or something you or I do?
Ah I see! Do you want to close your other PR then?
I have to do the version bump / upload to Ruby gems manually after this is merged. Are you able to merge this?
Ah I see! Do you want to close your other PR then?
I have to do the version bump / upload to Ruby gems manually after this is merged. Are you able to merge this?
It doesn't allow me to merge no. I'm wondering why the Github Checks are also not running.
I'll close the other PR
I just merged it so we can see what's up. There's a failure with Rails 4.2 it looks like e.g. https://github.com/mhgbrown/cached_resource/actions/runs/7499144125/job/20415403912
Any chance you can tackle that? Otherwise, I can look at it next week. In any event, thanks again for your contribution.
I just merged it so we can see what's up. There's a failure with Rails 4.2 it looks like e.g. https://github.com/mhgbrown/cached_resource/actions/runs/7499144125/job/20415403912
Any chance you can tackle that? Otherwise, I can look at it next week. In any event, thanks again for your contribution.
I'll look into it. Thanks
I just merged it so we can see what's up. There's a failure with Rails 4.2 it looks like e.g. https://github.com/mhgbrown/cached_resource/actions/runs/7499144125/job/20415403912
Any chance you can tackle that? Otherwise, I can look at it next week. In any event, thanks again for your contribution.
Issue was with differences in ActiveResource < 5.X and > 5.X
.
Please review https://github.com/mhgbrown/cached_resource/pull/60
Summary
Fixes: