[ISSUE-66] Add `cache_key_prefix` option

mhgbrown / cached_resource

Caching for ActiveResource

MIT License

80 stars 28 forks source link

[ISSUE-66] Add `cache_key_prefix` option #67

Closed jlurena closed 1 month ago

jlurena commented 2 months ago

Summary

Adds feature enhancement for:

https://github.com/mhgbrown/cached_resource/issues/66

Resolves issue:

https://github.com/mhgbrown/cached_resource/issues/65

jlurena commented 1 month ago

@mhgbrown please review

mhgbrown commented 1 month ago

There are some test failures, I think probably just because of concurrent incompatibility vs ruby version. I'll check it out later and/or if you have time, feel free to jump on it. https://github.com/mhgbrown/cached_resource/actions/runs/9839195796

jlurena commented 1 month ago

I'll get on it today @mhgbrown

Also anyway to enable CI on pull requests so we could see these errors ahead of time?

mhgbrown commented 1 month ago

Apparently I'm supposed to be seeing something to run the workflows explicitly....I haven't seen something so far. I think maybe the workflow needs some extra configuration...I'm not sure.