search

mhgbrown / cached_resource

Caching for ActiveResource
MIT License
80 stars 28 forks source link

Fix rails 4.2 failing specs #69

Closed jlurena closed 1 month ago

mhgbrown commented 1 month ago

I think what's causing the root of the problem is that setting concurrent_write doesn't re-require concurrent/promise and that's necessary for certain Ruby/Rails/whatever combinations. It looks like the only chance for it to get required is during setup. After requiring concurrent/promise explicitly in the spec helper, the build passes.

Does that sound right? I can look into ensuring that changing concurrent_write will require concurrent/promise

jlurena commented 1 month ago

Ah nice. Thanks..it's hard for me to test as I can't install ruby < 2.7 in my machine

mhgbrown commented 1 month ago

Got it, I'll get something going.

mhgbrown commented 1 month ago

Should we close this in favor of https://github.com/mhgbrown/cached_resource/pull/70?

jlurena commented 1 month ago

Yeah