mhgbrown / cached_resource

Caching for ActiveResource
MIT License
80 stars 28 forks source link

[ISSUE-68] Improved Specs and Added Coverage Report #70

Closed jlurena closed 1 month ago

jlurena commented 1 month ago

Summary

jlurena commented 1 month ago

@mhgbrown Any reason we are maintaining ruby < 3.0?

https://endoflife.date/ruby

Everything under 3.0 hit EOL

Edit: @mhgbrown if you'd consider this I also did the following:

mhgbrown commented 1 month ago

No particular reason other than to be most widely compatible. I'm down to move forward and support versions that are "living".

jlurena commented 1 month ago

This is great stuff and really moves the project forward. I left some questions for you.

It is done. Please review again. @mhgbrown

jlurena commented 1 month ago

This is great stuff and really moves the project forward. I left some questions for you.

It is done. Please review again. @mhgbrown

@mhgbrown I can merge but I'd need you to publish 😄

mhgbrown commented 1 month ago

I'll get on it later today

jlurena commented 1 month ago

I'll get on it later today

@mhgbrown 👀

mhgbrown commented 1 month ago

@jlurena Lawd, sorry. This week suddenly became a week of interviewing/doing a trial at a company. Why remove the concurrency option?

jlurena commented 1 month ago

@jlurena Lawd, sorry. This week suddenly became a week of interviewing/doing a trial at a company. Why remove the concurrency option?

After research and practical tests, it actually performed really bad. Tested with a redis cache and a memcache cache. Performance degraded significantly. It was visibly slower. @italijancic-th helped test

mhgbrown commented 1 month ago

ok got it! I'll merge it in!

mhgbrown commented 1 month ago

@jlurena finally released: https://rubygems.org/gems/cached_resource