search

mhinz / neovim-remote

:ok_hand: Support for --remote and friends.
MIT License
1.75k stars 83 forks source link

hint: Waiting for your editor to close the file... #112

Closed vito-c closed 5 years ago

vito-c commented 5 years ago

When I am inside a neovim terminal and I run git commit --amend then save and quit I am greeted with hint: Waiting for your editor to close the file... at my terminal ... I wait and wait and wait and nothing happens then I just and it goes away and the commit takes place it's very strange as it just started happening when I enabled some saml github thing.

vito-c commented 5 years ago

I think I see the issue I use ZZ to quit the buffer

mhinz commented 5 years ago

Yup, the buffer has to be deleted, but ZZ or :wq etc. just write the buffer and quit the window without deleting the actual buffer.

Running the git editor within :terminal is a bit of a hack and not as comfortable as just firing up another shell and running git commit there, but Use nvr as git editor at https://github.com/mhinz/neovim-remote#typical-use-cases shows a few ways to improve the experience!