search

mhkeller / indian-ocean

A library for reading in and writing out data (plus some useful filesystem functions) in Node.js.
https://mhkeller.github.io/indian-ocean/
MIT License
63 stars 14 forks source link

Multiple new lines seem to add an empty row #94

Open mhkeller opened 4 years ago

mhkeller commented 4 years ago

This is the same behavior as d3-dsv. Seems like another option would be to call .trim() before reading and expose an option to disable that if necessary. Indian ocean already strips out the BOM character so could make sense. i dont really see how loading in empty lines would ever be meaningful.

aubergene commented 4 years ago

I wouldn't change the API of d3-dsv, though it seems strange, also not something that I've encountered

mhkeller commented 4 years ago

It wouldn't be an api change just adding a trim here. Something like this: https://github.com/mhkeller/indian-ocean/pull/95

mhkeller commented 2 years ago

This is mostly done on the trim branch. Since it's a breaking change, I'm going to wait until this is done https://github.com/mhkeller/indian-ocean/issues/102