search

mhkeller / vega-lite-api-examples

A repository containing Vega-Lite-API implementations of all of the examples in the Vega-Lite gallery. Work in progress and contributors welcome!
6 stars 2 forks source link

Arc #3

Closed ray-turla closed 11 months ago

ray-turla commented 12 months ago

Changes

  1. arc_ordinal_theta
  2. arc_params
  3. arc_pie_pyramid
  4. arc_radial_histogram
  5. arc_radial
mhkeller commented 11 months ago

Thanks a bunch for putting these together! I left two notes to just remove those comments and I'll go ahead and merge this. The rationale for removing the comments is once these are done, it's best if they're all standardized so that they could be put into the online docs as easily as possible. Thanks again!

mhkeller commented 11 months ago

Thanks!

ray-turla commented 11 months ago

Thanks a bunch for putting these together! I left two notes to just remove those comments and I'll go ahead and merge this. The rationale for removing the comments is once these are done, it's best if they're all standardized so that they could be put into the online docs as easily as possible. Thanks again!

My bad on that one. I had that over looked. You're welcome. Thanks for letting me contribute. I got more coming!

mhkeller commented 11 months ago

Great! One question actually. I just saw in the readme you added a note about the type ordinal field not existing in the spec. But I do see it here

ray-turla commented 11 months ago

Great! One question actually. I just saw in the readme you added a note about the type ordinal field not existing in the spec. But I do see it here

I didn't touch that part of readme. I actually read that part prior to working on arc examples. I could remove it on the next PR.

mhkeller commented 11 months ago

Ah nevermind. That was my addition.