search

mhmdomer / ecommerce-laravel

An e-commerce Laravel application from start to finish (excluding payments and shipping) with clean and simple UI
http://vampireecommerce.herokuapp.com
MIT License
294 stars 111 forks source link

I have added a functionality to create a user account with the order #53

Closed OMOJUNIOR closed 1 year ago

OMOJUNIOR commented 1 year ago

Nice work, you can add payment and some validation to the checkout forms. I commented out the Mail::to('me@me.com')->send(new OrderPlaced($order)); email object out as well.

mhmdomer commented 1 year ago

Hey @OMOJUNIOR, thanks for your PR! I really don't think creating a user as a part of the checkout process is a good idea, especially with a default password of "password", also, hardcoding the email doesn't look good.