Refactored to Support Livewire v3

mhmiton / laravel-modules-livewire

Using Laravel Livewire in Laravel Modules package with automatically registered livewire components for every modules.

MIT License

187 stars 34 forks source link

Closed coolsam726 closed 1 year ago

coolsam726 commented 1 year ago

Livewire v3 is a ground-up rewrite of Livewire, with a few breaking changes.

The following are some of the changes that affect this package:

Livewire\\Commands namespace has moved to \Livewire\Features\SupportConsoleCommands\Commands
The default path for livewire components has moved from Http\\Livewire to Livewire

This PR is intended for the next major release of the package since it doesn't have backward compatibility with Livewire 2.

mhmiton commented 1 year ago

@coolsam726 Thanks for this PR. I will merge this soon.

tomgrv commented 1 year ago

This PR is intended for the next major release of the package since it doesn't have backward compatibility with Livewire 2.

It should be a v2.0.0 then ?

mhmiton commented 1 year ago

@tomgrv Sorry, I did not understand properly. Do you mean that, the latest release version should be v2.0.0 instead of v1.7.0 for this package?

tomgrv commented 1 year ago

@tomgrv Sorry, I did not understand properly. Do you mean that, the latest release version should be v2.0.0 instead of v1.7.0 for this package?

Sorry for the lack of clarity.

Yes, since you introduce a breaking change, version should be 2.0.0 to reflect it (as per semver guidelines) it and prevent automatic updates.

mhmiton commented 1 year ago

@tomgrv Oh, ok. Thanks for your suggestions. I will change it.