mhmiton / laravel-modules-livewire

Using Laravel Livewire in Laravel Modules package with automatically registered livewire components for every modules.
MIT License
187 stars 34 forks source link

change path from Resources to resources #41

Closed philipnjuguna66 closed 8 months ago

philipnjuguna66 commented 8 months ago

In Laravel modules version 10, the resource paths are in lowercase. Therefore, this pull request adjusts the resource paths from uppercase to lowercase to align with the convention used in version 10 of Laravel modules.

dcblogdev commented 8 months ago

hmm the trouble is it's not strictly set that way, anyone can change the paths from upper to lowercase as they want. Seems to work fine in either case.

I don't think this is needed.

Here I have 2 modules one with Resources and one with resources both work without any changes

Screenshot 2024-03-18 at 18 10 00

Blog

Screenshot 2024-03-18 at 18 12 08

Docs

Screenshot 2024-03-18 at 18 12 48
Filefabrik commented 8 months ago

@philipnjuguna66

while php artisan vendor:publish --tag=modules-livewire-config have a look in Laravel-Root1 '/config/modules-livewire.php'

` /* -------------------------------------------------------------------------- View Path
*/

'view' => 'Resources/views/livewire',

` change to

` /* -------------------------------------------------------------------------- View Path
Lover-Cased :))
*/

'view' => 'resources/views/livewire',

`

That should work