search

mhogomchungu / media-downloader

Media Downloader is a Qt/C++ front end to yt-dlp, youtube-dl, gallery-dl, lux, you-get, svtplay-dl, aria2c, wget and safari books..
GNU General Public License v2.0
1.61k stars 122 forks source link

missing wget and ffmpeg #104

Closed TeLLie closed 2 years ago

TeLLie commented 2 years ago

Hi I compiled it for OS2 and use qt5 v5.15.2 and gcc 9.2.0 But when running the program i see in log:

[media-downloader] [media-downloader] To Disable These Checks, Do The Following:- [media-downloader] 1. Go To "Configure" Tab. [media-downloader] 2. Go To "General Options" Sub Tab. [media-downloader] 3. Uncheck "Show Version Info When Starting". [media-downloader] [media-downloader] Failed to find executable "wget" [media-downloader] Error, executable to backend "wget" could not be found [media-downloader] Failed to find executable "ffmpeg" [media-downloader] Error, executable to backend "ffmpeg" could not be found [media-downloader] Failed to find executable "aria2c" [media-downloader] Error, executable to backend "aria2c" could not be found [media-downloader] Checking installed version of yt-dlp [media-downloader] Found version: 2022.03.08.1 [media-downloader] Checking installed version of youtube-dl [media-downloader] Found version: 2021.12.17 [media-downloader] Checking installed version of yt-dlp-ffmpeg [media-downloader] Found version: 2022.03.08.1

Any idea?

mhogomchungu commented 2 years ago

Bundling happens in Windows only.

Install those missing executables using your system's way of installing executables and Media Downloader should be able to pick them up.

TeLLie commented 2 years ago

Hi Thankz for answer, but this is with os/2 to. I have all in path but it still don't see those. Also copied to same dir as the exe is , but same..

Op do 10 mrt. 2022 08:17 schreef mhogomchungu @.***>:

Bundling happens in Windows only.

Install those missing executables using your system's way of installing executables and Media Downloader should be able to pick them up.

— Reply to this email directly, view it on GitHub https://github.com/mhogomchungu/media-downloader/issues/104#issuecomment-1063736990, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYTRASW5ZQGSMGIGAIKJ3U7GOW5ANCNFSM5QKNUIPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

mhogomchungu commented 2 years ago

I think the problem is here[1], os/2 uses window's path separator.

How can i identify OS/2 at runtime or at compile time? The Qt list of macro to identify operating systems at compile time starts here[2] and os/2 is not on the list.

[2] https://doc.qt.io/qt-5/qtglobal.html#Q_OS_AIX

[1] https://github.com/mhogomchungu/media-downloader/blob/7b03de5fd7dfca393685e441705f42aa7f6edcb2/src/engines.cpp#L49-L57

mhogomchungu commented 2 years ago

Update from git and try again

TeLLie commented 2 years ago

Hi I did a git update This is output... weakld: error: Unresolved symbol (UNDEF) 'ZN7utility11python3PathEv'. weakld: info: The symbol is referenced by: D:\temp\ldconv_engines_cpp_o_378622a866512d2a8.obj weakld: error: Unresolved symbol (UNDEF) 'ZN7utility13platformIsOSXEv'. weakld: info: The symbol is referenced by: D:\temp\ldconv_settings_cpp_o_378622a8649111170.obj D:\temp\ldconv_engines_cpp_o_378622a866512d2a8.obj weakld: error: Unresolved symbol (UNDEF) 'ZN7utility15platformIsLinuxEv'. weakld: info: The symbol is referenced by: D:\temp\ldconv_configure_cpp_o_378622a8659184530.obj D:\temp\ldconv_lux_cpp_o_378622a8677165518.obj weakld: error: Unresolved symbol (UNDEF) 'ZN7utility17platformIsWindowsEv'. weakld: info: The symbol is referenced by: D:\temp\ldconv_settings_cpp_o_378622a8649111170.obj D:\temp\ldconv_utility_cpp_o_378622a864b1399e0.obj D:\temp\ldconv_about_cpp_o_378622a865017eb58.obj D:\temp\ldconv_batchdownloader_cpp_o_378622a865316e1b8.obj D:\temp\ldconv_networkAccess_cpp_o_378622a86601952b8.obj D:\temp\ldconv_engines_cpp_o_378622a866512d2a8.obj D:\temp\ldconv_safaribooks_cpp_o_378622a86711762a0.obj D:\temp\ldconv_lux_cpp_o_378622a8677165518.obj Ignoring unresolved externals reported from weak prelinker. Error! E2028: ZN7utility17platformIsWindowsEv is an undefined reference Error! E2028: ZN7utility13platformIsOSXEv is an undefined reference Error! E2028: ZN7utility15platformIsLinuxEv is an undefined reference Error! E2028: ZN7utility11python3PathEv is an undefined reference file D:/temp\ldconv_settings_cpp_o_378622a8649111170.obj(G:\media-downloader\src\settings.cpp): undefined symbol ZN7utility17platformIsWindowsEv file D:/temp\ldconv_settings_cpp_o_378622a8649111170.obj(G:\media-downloader\src\settings.cpp): undefined symbol ZN7utility13platformIsOSXEv file D:/temp\ldconv_utility_cpp_o_378622a864b1399e0.obj(G:\media-downloader\src\utility.cpp): undefined symbol ZN7utility17platformIsWindowsEv file D:/temp\ldconv_about_cpp_o_378622a865017eb58.obj(G:\media-downloader\src\about.cpp): undefined symbol ZN7utility17platformIsWindowsEv file D:/temp\ldconv_batchdownloader_cpp_o_378622a865316e1b8.obj(G:\media-downloader\src\batchdownloader.cpp): undefined symbol ZN7utility17platformIsWindowsEv file D:/temp\ldconv_configure_cpp_o_378622a8659184530.obj(G:\media-downloader\src\configure.cpp): undefined symbol ZN7utility15platformIsLinuxEv file D:/temp\ldconv_networkAccess_cpp_o_378622a86601952b8.obj(G:\media-downloader\src\networkAccess.cpp): undefined symbol ZN7utility17platformIsWindowsEv file D:/temp\ldconv_engines_cpp_o_378622a866512d2a8.obj(G:\media-downloader\src\engines.cpp): undefined symbol ZN7utility17platformIsWindowsEv file D:/temp\ldconv_engines_cpp_o_378622a866512d2a8.obj(G:\media-downloader\src\engines.cpp): undefined symbol ZN7utility11python3PathEv file D:/temp\ldconv_engines_cpp_o_378622a866512d2a8.obj(G:\media-downloader\src\engines.cpp): undefined symbol ZN7utility13platformIsOSXEv file D:/temp\ldconv_safaribooks_cpp_o_378622a86711762a0.obj(G:\media-downloader\src\engines\safaribooks.cpp): undefined symbol ZN7utility17platformIsWindowsEv file D:/temp\ldconv_lux_cpp_o_378622a8677165518.obj(G:\media-downloader\src\engines\lux.cpp): undefined symbol ZN7utility17platformIsWindowsEv file D:/temp\ldconv_lux_cpp_o_378622a8677165518.obj(G:\media-downloader\src\engines\lux.cpp): undefined symbol __ZN7utility15platformIsLinuxEv make[2]: [media-downloader.exe] Error 1 make[1]: [CMakeFiles/media-downloader.dir/all] Error 2 make: *** [all] Error 2

I saw that u use platformisOS2 instead of platformIsOS2

Also i use this in utility.cpp

--- G:\media-downloader\src\utility.cpp 2022-03-10 18:13:30.000000000 -0500 +++ G:\media-downloader\src\utility.cpp-os2 2022-03-10 17:59:34.000000000 -0500 @@ -38,17 +38,14 @@ const char utility::selectedAction::CLEARSCREEN = "Clear Screen" ; const char utility::selectedAction::OPENFOLDER = "Open Download Folder" ;

+//#ifdef Q_OS_LINUX +#if defined(Q_OS_LINUX) || defined(Q_OS_OS2) + bool utility::platformIsOS2() { -#if defined(OS2) || defined(OS2) || defined(_OS2) return true ; -#else

-#ifdef Q_OS_LINUX

bool utility::platformIsLinux() { return true ;

mhogomchungu commented 2 years ago

Your changes will make it fail to compile on windows and MACOS, update from git and it should compile now.

When running from git, did it work?

mhogomchungu commented 2 years ago

While here, what is the contents of the "PATH" environmental variable in your OS/2 system?

TeLLie commented 2 years ago

Hi Yes compiled now. Only i see its downloading the exe file [media-downloader] Start Downloading yt-dlp ... ... ... [media-downloader] Downloading: https://github.com/yt-dlp/yt-dlp/releases/download/2022.03.08.1/yt-dlp_x86.exe [media-downloader] Destination: C:/Home/.local/share/media-downloader/bin/yt-dlp_x86.exe.tmp

it should be like before

[media-downloader] Checking installed version of yt-dlp [media-downloader] Found version: 2022.03.08.1 [media-downloader] Checking installed version of youtube-dl [media-downloader] Found version: 2021.12.17 [media-downloader] Checking installed version of yt-dlp-ffmpeg [media-downloader] Found version: 2022.03.08[media-downloader] Checking installed version of yt-dlp [media-downloader] Found version: 2022.03.08.1 [media-downloader] Checking installed version of youtube-dl [media-downloader] Found version: 2021.12.17 [media-downloader] Checking installed version of yt-dlp-ffmpeg [media-downloader] Found version: 2022.03.08

TeLLie commented 2 years ago

Oeps, the content of the path enviroment = PATH=C:\usr\libexec\bin;C:\SYS\BIN;C:\OS2;C:\USR\LOCAL\BIN;C:\USR\SBIN;C:\USR\BIN;C:\IBMLAN\NETPROG;C:\MUGLIB;C:\PROGRAMS\NETSCAPE\PROGRAM;C :\IBMGSK50\BIN;C:\IBMGSK40\BIN;C:\IBMGSK\BIN;C:\MPTN\BIN;C:\TCPIP\BIN;C:\IBMCOM;C:\OS2\SYSTEM;C:\OS2\MDOS\WINOS2;C:\OS2\INSTALL;C:\;C:\OS2\M DOS;C:\OS2\APPS;C:\MMOS2\FREEDB;C:\MMOS2;C:\MMOS2\MMPLAYER;C:\PROGRAMS\NDFS;C:\SYS\APPS\4OS2;C:\PROGRAMS\ARCTOOL;C:\PROGRAMS\OPENJDK\BIN;; The exe files are in usr/bin

mhogomchungu commented 2 years ago

Try now from git

TeLLie commented 2 years ago

ok thats fixed

But still see [media-downloader] ***** [media-downloader] Failed to find executable "wget" [media-downloader] Error, executable to backend "wget" could not be found [media-downloader] Failed to find executable "ffmpeg" [media-downloader] Error, executable to backend "ffmpeg" could not be found

mhogomchungu commented 2 years ago

Are you sure you have ffmpeg installed?

Copy "ffmpeg" executable to where Media Downloader is downloding yt-dlp(C:/Home/.local/share/media-downloader/bin/) and restart it and see if it makes a difference.

TeLLie commented 2 years ago

That makes no diff

C:\Home.local\share\media-downloader\bin>wget -V GNU Wget 1.20.3 built on os2-emx.

C:\Home.local\share\media-downloader\bin>ffmpeg -V ffmpeg version 4.2.2 Copyright (c) 2000-2019 the FFmpeg developers built with gcc 9 (GCC) So those are installed

mhogomchungu commented 2 years ago

Update from git and try again.

Open the terminal and run "media-downloader --debug" and post the output of those version checks.

It does not make sense why yt-dlp can be found but ffmpeg can not if they are both in the same folder.

TeLLie commented 2 years ago

Hi First thankz for helping this out :)

[media-downloader] ***** [media-downloader] Failed to find executable "aria2c" [media-downloader] Error, executable to backend "aria2c" could not be found [media-downloader] Checking installed version of yt-dlp [media-downloader] cmd: "C:/Home/.local/share/media-downloader/bin/yt-dlp" "--version" [media-downloader] Found version: 2022.03.08.1 [media-downloader] Checking installed version of wget [media-downloader] cmd: "C:/USR/BIN/wget.exe" "--version" [media-downloader] Found version: 1.20.3 [media-downloader] Checking installed version of youtube-dl [media-downloader] cmd: "C:/Home/.local/share/media-downloader/bin/youtube-dl" "--version" [media-downloader] Found version: 2021.12.17 [media-downloader] Checking installed version of yt-dlp-ffmpeg [media-downloader] cmd: "C:/Home/.local/share/media-downloader/bin/yt-dlp" "--version" [media-downloader] Found version: 2022.03.08.1 [media-downloader] Checking installed version of ffmpeg [media-downloader] cmd: "C:/USR/BIN/ffmpeg.exe" "-version" [media-downloader] Found version: 4.2.2

mhogomchungu commented 2 years ago

This commit[1] seems to have fix the issue.

Closing this bug report because the reported issue is now fixed.

[1] https://github.com/mhogomchungu/media-downloader/commit/195e56cc8a0027f32ca0fee20a47b1ba749f4749

TeLLie commented 2 years ago

Yes its workinf fine now . Thankz again for all the great help :)

TeLLie commented 1 year ago

Hi

I compiled latest source but i get...

[media-downloader] Failed to find executable "aria2c.exe" [media-downloader] Error, executable to backend "aria2c" could not be found [media-downloader] [media-downloader] To Disable These Checks, Do The Following:- [media-downloader] 1. Go To "Configure" Tab. [media-downloader] 2. Go To "General Options" Sub Tab. [media-downloader] 3. Uncheck "Show Version Info When Starting". [media-downloader] [media-downloader] Download Path: C:/Home/Downloads [media-downloader] App Data Path: C:/Home/.local/share/media-downloader [media-downloader] ***** [media-downloader] Checking installed version of yt-dlp [media-downloader] Failed to find version information, make sure "yt-dlp" is installed and works properly [media-downloader] Checking installed version of ffmpeg [media-downloader] Failed to find version information, make sure "ffmpeg" is installed and works properly

Did the source changed ?

mhogomchungu commented 1 year ago

Update from git and try again and run it from CLI with "--debug" option set.

TeLLie commented 1 year ago

Hi If i use cmd line with --debug i get no relevant info...

But when starting i see...

media-downloader] ***** [media-downloader] Checking installed version of yt-dlp [media-downloader] cmd: "C:/Home/.local/share/media-downloader/bin/yt-dlp" "--version" [media-downloader] Failed to find version information, make sure "yt-dlp" is installed and works properly [media-downloader] Checking installed version of ffmpeg [media-downloader] cmd: "C:\USR\BIN/ffmpeg.exe" "-version" [media-downloader] Failed to find version information, make sure "ffmpeg" is installed and works properly [media-downloader] Start Downloading yt-dlp ... ... [media-downloader] Downloading: https://github.com/yt-dlp/yt-dlp/releases/download/2023.09.24/yt-dlp [media-downloader] Destination: C:/Home/.local/share/media-downloader/bin/yt-dlp.tmp [media-downloader] Downloading yt-dlp: 2.79 MiB / 2.79 MiB (100.00%) [media-downloader] Download complete [media-downloader] Renaming file to: C:/Home/.local/share/media-downloader/bin/yt-dlp [media-downloader] Checking installed version of yt-dlp [media-downloader] cmd: "C:/Home/.local/share/media-downloader/bin/yt-dlp" "--version" [media-downloader] Failed to find version information, make sure "yt-dlp" is installed and works properly

It seems to download but cannot get version info...

from cmdline i see: C:\Home.local\share\media-downloader\bin>ffmpeg.exe -version gives no info

C:\Home.local\share\media-downloader\bin>ffmpeg.exe --version ffmpeg version 4.2.2 Copyright (c) 2000-2019 the FFmpeg developers built with gcc 9 (GCC)

C:\Home.local\share\media-downloader\bin>python --version Python 3.9.17

mhogomchungu commented 1 year ago
  1. ffmpeg 4.2.2 was released in 2019 and perhaps older versions use "--version" while newer ones use "-version", why are using a very old version?
  2. I do not see errors with wget.
  3. What does below command give you when you run it from the terminal.
"C:/Home/.local/share/media-downloader/bin/yt-dlp" "--version"
TeLLie commented 1 year ago

Hi,

It's the only rpm we have atm, can try to build newer.. Wget is not mention at all, as I have wget installed The version output 2023.09.24

Run python yt-dlp --version

mhogomchungu commented 1 year ago

Your comments is not clear what you are getting when you run the following command

"C:/Home/.local/share/media-downloader/bin/yt-dlp" "--version"
TeLLie commented 1 year ago

Hi

With os2 we use python yt-dlp --version And the output is "2023-09.24"

As I run just yt-dlp --version it says "it's not a internal or external operable program or batch file"

with kind regards, Elbert & Nicole Pol

Op wo 4 okt. 2023 20:44 schreef mhogomchungu @.***>:

Your comments is not clear what you are getting when you run the following command

"C:/Home/.local/share/media-downloader/bin/yt-dlp" "--version"

— Reply to this email directly, view it on GitHub https://github.com/mhogomchungu/media-downloader/issues/104#issuecomment-1747447616, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYTRC7BIFMDUWTMLIN2XDX5WVBLAVCNFSM5QKNUIPKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZUG42DINZWGE3A . You are receiving this because you authored the thread.Message ID: @.***>

mhogomchungu commented 1 year ago

You can make Media Downloader work with your version of ffmpeg by changing this line.

Do the following to make python run yt-dlp.

  1. Go to C:/Home/.local/share/media-downloader/engines.v1 folder.
  2. Open yt-dlp.json text file with a text editor.
  3. Look at the text file and you will see below section.
  4. In the "Args" part, replace "yt-dlp" text with "python","yt-dlp" text,
  5. Save the file and restart Media Downloader. 
    "Generic": {
        "amd64": {
            "Args": [
                "yt-dlp"
            ],
            "Name": "yt-dlp"
        },
        "x86": {
            "Args": [
                "yt-dlp"
            ],
            "Name": "yt-dlp"
        }
    },
TeLLie commented 1 year ago

Hi, It's all working again, as it where errors in my env, that makes things not run properly.. also ffmpeg works with just 1 -

I just rebuild my usr dir.

Sorry for mixed up things...

with kind regards, Elbert & Nicole Pol

Op wo 4 okt. 2023 21:51 schreef mhogomchungu @.***>:

You can make Media Downloader work with your version of ffmpeg by changing this https://github.com/mhogomchungu/media-downloader/blob/e1bb0c31ab23a454f3154fe2815f84125da8bf48/src/engines.cpp#L332 line.

Do the following to make python run yt-dlp.

  1. Go to C:/Home/.local/share/media-downloader/engines.v1 folder.
  2. Open yt-dlp.json text file with a text editor.
  3. Look at the text file and you will see below section.
  4. In the "Args" part, replace "yt-dlp" text with "python","yt-dlp" text,
  5. Save the file and restart Media Downloader.

"Generic": { "amd64": { "Args": [ "yt-dlp" ], "Name": "yt-dlp" }, "x86": { "Args": [ "yt-dlp" ], "Name": "yt-dlp" } },

— Reply to this email directly, view it on GitHub https://github.com/mhogomchungu/media-downloader/issues/104#issuecomment-1747539520, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYTRGPYSKWEC6Z6UNQPQDX5W45TAVCNFSM5QKNUIPKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZUG42TGOJVGIYA . You are receiving this because you authored the thread.Message ID: @.***>

TeLLie commented 1 year ago

Hi

When I change line 1092 from engines.cpp to platformislikewindows I also get the wget, included the version info...

with kind regards, Elbert & Nicole Pol

Op do 5 okt. 2023 22:26 schreef Elbert Pol @.***>:

Hi, It's all working again, as it where errors in my env, that makes things not run properly.. also ffmpeg works with just 1 -

I just rebuild my usr dir.

Sorry for mixed up things...

with kind regards, Elbert & Nicole Pol

Op wo 4 okt. 2023 21:51 schreef mhogomchungu @.***>:

You can make Media Downloader work with your version of ffmpeg by changing this https://github.com/mhogomchungu/media-downloader/blob/e1bb0c31ab23a454f3154fe2815f84125da8bf48/src/engines.cpp#L332 line.

Do the following to make python run yt-dlp.

  1. Go to C:/Home/.local/share/media-downloader/engines.v1 folder.
  2. Open yt-dlp.json text file with a text editor.
  3. Look at the text file and you will see below section.
  4. In the "Args" part, replace "yt-dlp" text with "python","yt-dlp" text,
  5. Save the file and restart Media Downloader.

"Generic": { "amd64": { "Args": [ "yt-dlp" ], "Name": "yt-dlp" }, "x86": { "Args": [ "yt-dlp" ], "Name": "yt-dlp" } },

— Reply to this email directly, view it on GitHub https://github.com/mhogomchungu/media-downloader/issues/104#issuecomment-1747539520, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYTRGPYSKWEC6Z6UNQPQDX5W45TAVCNFSM5QKNUIPKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZUG42TGOJVGIYA . You are receiving this because you authored the thread.Message ID: @.***>

mhogomchungu commented 1 year ago

Line 1092 in engines.cpp does not point to where you say it is pointing.

9a4f530f8221f36907bbfb78ff0c57c3dd1c/src/engines.cpp#L1092

TeLLie commented 1 year ago

Hi

Oeps it's line 2097

with kind regards, Elbert & Nicole Pol

Op vr 6 okt. 2023 17:52 schreef mhogomchungu @.***>:

Line 1092 in engines.cpp does not point to anything

9a4f530f8221f36907bbfb78ff0c57c3dd1c/src/engines.cpp#L1092 https://github.com/mhogomchungu/media-downloader/blob/22649a4f530f8221f36907bbfb78ff0c57c3dd1c/src/engines.cpp#L1092

— Reply to this email directly, view it on GitHub https://github.com/mhogomchungu/media-downloader/issues/104#issuecomment-1750969588, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIYTRHXEHUN3DFGQ4VZVBDX6ASKPAVCNFSM5QKNUIPKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZVGA4TMOJVHA4A . You are receiving this because you authored the thread.Message ID: @.***>