search

mhogomchungu / media-downloader

Media Downloader is a Qt/C++ front end to yt-dlp, youtube-dl, gallery-dl, lux, you-get, svtplay-dl, aria2c, wget and safari books..
GNU General Public License v2.0
1.6k stars 119 forks source link

Windows uninstaller - Generic icon #264

Closed bovirus closed 1 year ago

bovirus commented 1 year ago

@mhogomchungu

In file

https://github.com/mhogomchungu/media-downloader/blob/main/CMakeLists.txt

is defined

UninstallDisplayIcon={#MySourcesPath}\src\media-downloader.ico

probably there is some issues about this file or path because in the Windows program list after install 3.8.0 appear the program with a generic icon (see screenshot)

image

I believe that the strings should be

UninstallDisplayIcon={app}\{#MyAppExeName}

because the icon is get nor from source but the installed program.

Thanks.

mhogomchungu commented 1 year ago

Done, thanks.

https://github.com/mhogomchungu/media-downloader/commit/6d27f051ad4077da88113066c5effffab6e4ae08