search

mhogomchungu / media-downloader

Media Downloader is a Qt/C++ front end to yt-dlp, youtube-dl, gallery-dl, lux, you-get, svtplay-dl, aria2c, wget and safari books..
GNU General Public License v2.0
1.34k stars 101 forks source link

Misspelling in one of the preset options. #394

Closed kolbdog323 closed 2 months ago

kolbdog323 commented 2 months ago

Just letting you know you have this spelled wrong Best Audio and Video for MPV. It's suppoed to be MKV not MPV.

mhogomchungu commented 2 months ago

Can you post a screenshot that shows the misspelling?

kolbdog323 commented 2 months ago

Here you go:

for online

mhogomchungu commented 2 months ago

You must have added the option yourself, the last part of the code that initially populate the list is below and the problematic entry is not in the code.

https://github.com/mhogomchungu/media-downloader/blob/513b8bc56870865d57696fe093ebedba9f473009/src/configure.cpp#L1316-L1337

kolbdog323 commented 2 months ago

Nope i have never touched the code once. I wouldn't even know where to fix it manually. Edit: Never mind.

kolbdog323 commented 2 months ago

I found it and fixed it. Maybe you can add that option in for people who want the best mkv since a lot of times that file size is smaller then the mp4 format. And same quality as the avc version just smaller file size most of the time since it grabs the highest quality webm and m4a.

Here is the code:

"options": "-f bestvideo[ext=webm]+bestaudio[ext=m4a]", "uiName": "Best Audio and Video for MKV", "website": "Youtube"

mhogomchungu commented 2 months ago

The UI place to add options to the list is at "Configure Tab->Preset Options subtab".

Either you or somebody else added the options and mistyped the entry in the "Ui Name" text field because Media Downloader adds no such entry by itself.

The default list is already too long already and i do not think this addition will add too much value and will just open up a door for others to ask for other default entries that downloads webm by default.

Webm videos are discouraged by default in Media Downloader because they do not work everywhere.