search

mhogomchungu / zuluCrypt

zuluCrypt is a front end to cryptsetup and tcplay and it allows easy management of encrypted block devices
https://mhogomchungu.github.io/zuluCrypt
Other
513 stars 61 forks source link

unnecessary duplicate of png icons (zulu*-gui) #81

Closed Piraty closed 6 years ago

Piraty commented 6 years ago

https://github.com/mhogomchungu/zuluCrypt/blob/722ec332f7ef80e30c0e45a43ff896875d2473be/zuluCrypt-gui/CMakeLists.txt#L143 https://github.com/mhogomchungu/zuluCrypt/blob/722ec332f7ef80e30c0e45a43ff896875d2473be/zuluMount-gui/CMakeLists.txt#L106

That copy of .png icons is probably unnecessary, as they already reside in pixmaps and icons/hicolor/48x48/apps.

mhogomchungu commented 6 years ago

I did this on purpose because i was not sure what DE picks up icons from what folder and decided to put the icons everywhere i could think of as a mean of making sure the icons will be picked up by everybody.

Some DE caches icons and this makes it harder when trying to figure out what path works and what path does not.

Is this causing a problem somewhere?

Piraty commented 6 years ago

no problem i know of, it's just redundant.