Only skip first n lines in the first chunk and don't take the first line as header (#1045)

mholt / PapaParse

Fast and powerful CSV (delimited text) parser that gracefully handles large files and malformed input

http://PapaParse.com

MIT License

12.3k stars 1.14k forks source link

Open jkruke opened 4 months ago

jkruke commented 4 months ago

References #1045

foobarnes commented 2 months ago

@jkruke @pokoli Is this ready to merge? Can I do any work on it to get it through? Pretty essentially on our end.

jkruke commented 2 months ago

Actually, the reviewer @pokoli should re-review my actions regarding to his comments
From my point of view, no further work needs to be done then

foobarnes commented 2 months ago

@pokoli Any update here?

jkruke commented 2 months ago

To get this done, maybe @foobarnes you wanna approve+merge this PR instead? :)

foobarnes commented 1 month ago

My bad, didn't realize I had permissions!

jkruke commented 1 month ago

Hmm it's still not mergable because of unapproved changes, can we approve them somehow?