search

mholt / PapaParse

Fast and powerful CSV (delimited text) parser that gracefully handles large files and malformed input
http://PapaParse.com
MIT License
12.44k stars 1.14k forks source link

Issues in new version of papaparse #675

Open kroupacz opened 5 years ago

kroupacz commented 5 years ago

Hello, after upgrade to papaparse 5.0.0, I have a problem with correct delimiter detection and "header": true config. It look like this issue is related to this commit/change: https://github.com/mholt/PapaParse/commit/f6b1b36c3f8faf5ab8e436709925e1563b0f75de

Below I am sending two files where the problem occurs.

Both of these files are correctly parsed in papaparse version 4.6.1.

Thank you for fixing this issue. Tomáš

georgeslabreche commented 5 years ago

I believe this is the same issue: https://github.com/mholt/PapaParse/issues/685

pokoli commented 5 years ago

Could you test this is fixed on current master? #687 may have fixed this.

seth-shaw-unlv commented 5 years ago

I don't believe #685 is a duplicate of this issue. I've posted my example on that thread and the current master doesn't resolve the issue.

georgeslabreche commented 5 years ago

I do apologize for mistakingly relating the two different issues!

martinstreicher commented 4 years ago

I have a perfectly valid CSV file that will not upload properly in Papa 5 with header: true. It worked fine previously. However, if I also enable the Skip empty lines feature, the file processes just fine. Oddly though, there are no blank lines in the file. Further, the error in parsing always seems to occur on the final line of the file.

pokoli commented 4 years ago

@martinstreicher It will be great if you can share the file or add a simple test case to reproduce the issue. Otherwise it is not possible to provide a fix for it.