Open dboskovic opened 4 years ago
:+1: for Typescript! (or at least an official .d.ts file!)
Hi @dboskovic,
First of all thank you so much for all the effort put on your issue. I think they are very nice proposals and we should go forward and implement most of them. I have some concers I will like to discuss without going forward:
I do not much the idea of a backwards compatible layer. I prefer to have a timeline to support the 5.0x series, so we fix issues on this branch while allowing users to test the new version.
For the documentation we only need to generate some static files in html format than can be latter uploaded to our website, so any dynamism here makes sense. I think that we can change the documentation format without requiring a new version to be released.
For all the other points, please go forward on them and strat creating PR for them! My idea is to release 5.2.0 before merging breaking changes to master branch.
Thanks, I'm new to javascript and I was able to read a csv with your website example and your documentation it's good.
I also like the idea of getting core parts available on their own for less complex situations. Thank you, Cheers
Alex
es7 + jsdoc and/or d.ts
wish to be able to use native import in browser without having to bundle or transpile the scripts. typescript is not javascript and dose not work in browser. (and for the record use full path with extension so browser can properly require related files)
if you would like to write cross node/browser maybe you should consider abending streams and use async iterator instead
It would be great to provide an ES module build. Most javascript packages provide both a node.js build, and an ES module build. If you use tools like Webpack or Rollup (recommended) it is simply a case of specifying in the config you would like to additionally output a module build, which is then referenced for example module:
es_module/index.jsin
package.json`. At the moment, I am not able to bundle PapaParse with Rollup. I assume that other users are either not bundling and simply including the browser script, or they are using Webpack, which is the most popular tool, however rollup is the second most popular and very heavily used.
I would like to see support for streaming data from node as it is unparsed as per #568 and #652.
I would like to see support for streaming data from node as it is unparsed as per #568 and #652.
But please implement it in a way that this library still can be used in browser ;)
Promises because it's 2019 (shim for legacy browsers)
Maybe move the milestone to async/await for 2021 😄
I wish you would use a async generator instead of importing node streams https://github.com/cross-js/cross-js#dont-create-node-or-web-readable-stream-yourself
(or use whatwg stream on nodejs) so it could work grate across Web/Deno/NodeJS
I wish you would use a async generator instead of importing node streams https://github.com/cross-js/cross-js#dont-create-node-or-web-readable-stream-yourself
(or use whatwg stream on nodejs - node just shipped it as experimental) so it could work grate across Web/Deno/NodeJS
Async iterator is the main reason I decided to use csv-parse over papaparse even though there is a slight performance penalty.
Async iterator is the main reason I decided to use csv-parse over papaparse even though there is a slight performance penalty.
I do it for similar reasons on other libraries as well just for better cross environment compatibility. and not having to import a hole node module into browsers
reason why it can be slower is that it don't have a bucket. the highwatermark is basically 1
a grate way to boost it doe is to use const newAsyncIterable = stream.Readable.from(iterator, { highWaterMark: x })
Would it be possible to have async functions for step
? Let's say I need to store each parsed row in a database (e.g. indexeddb or some remote (no-)SQL database) that has an async interface. Currently I build an array and the process the array in complete
. Having step being async
and having the parser await the promise returned by step
would allow me to avoid that.
Edit: Of course I can use pause and resume (though not if using a worker, according to the docs). It does address my immediate need, but having the possibility of step
being async is much more elegant and easier to write and read.
PapaParse has been a pleasure to use. I'm late to the party, but here's my wishlist:
step
until I have batch_size rows, then process them all. Being able to use step and set a 'batch_size' would be great, but at the expense of bloating the library and documentation just a tad.Guys you need to implement this specification, to allow much more complex structures. https://csvjson.org/ https://csvjson.com/csvjson2json
anyway, this is a nice tool, congrats...
I think an update should strive to add as little new stuff as possible. Instead, try to reduce the surface, making the project easier to maintain.
I would remove the following:
On typescript, it's double-edged. Yes, easier to maintain when you know it, but also harder for people to contribute to the project. Also, pretty large rewrite, not necessarily worth it.
Also, instead of plugins, just provide a few simple callback JS hooks. For example beforeParse
, afterParse
, etc. that people can use for customization.
Much less work to maintain than a full-fledged plugin system.
Also, since Node 18 has a native fetch implementation, would it be possible to shift from XMLHttpRequest to Fetch? This would enable the remove CSV parsing option for Node backends!
@rohanrajpal what about users running PapaParse on the browser? Do we also have a fetch implementation available on browsers?
@rohanrajpal what about users running PapaParse on the browser? Do we also have a fetch implementation available on browsers?
It is available, right? https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API
I happen to use fetch() only for our frontend API calls, or am I confusing Fetch with something else here? Still new to this world of web dev so I might be wrong here.
@pokoli @rohanrajpal The fetch API (https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API) was a browser only (or at least not in node) API up until recently. There has been a package to implement the behaviour of fetch called node-fetch
(https://www.npmjs.com/package/node-fetch). As of node v18, there exists a native, experimental fetch implementation: https://nodejs.org/en/blog/announcements/v18-release-announce.
@Elias-Graf thanks for the info. The problem is that we need to support all maintaned versions of node so until node16 is unmaintained we can not introduce features of node18.
@pokoli I'm aware. I was just trying to clarify what https://github.com/mholt/PapaParse/issues/748#issuecomment-1317051187 said.
Btw. I have quite a bit of TypeScript experience, if you guys need help with that :)
Hi, is there any progress, to get papaparse as an es module? I have problems with vite 4, because version 5 is only available for commonjs.
Thanks for your work on this project :-)
I'd love to be part of the conversion to a functional programming model. So much of what I see here seems to easily translate to that, and making the data/variable flows easier to track would be a joy to behold.
On point 2 "Separate NodeJS build from Browser build" - there has been so much standardisation between Node and web browsers now (and ideally people could also use this in non-Node backend environments like Deno and Bun) couldn't you just make the code interoperable rather easily? Maybe use web streams instead of Node streams?
When could we start?I am glad to contribute to it.
I wish you would use a async generator instead of importing node streams
Is there a clever way anyone can think of to make an async generator wrapper function around papaparse.parse(stream, { step, complete })
?
Related: https://stackoverflow.com/questions/50862698/how-to-convert-node-js-async-streaming-callback-into-an-async-generator https://stackoverflow.com/questions/63749853/possible-to-make-an-event-handler-wait-until-async-promise-based-code-is-done
@Elias-Graf thanks for the info.
The problem is that we need to support all maintaned versions of node so until node16 is unmaintained we can not introduce features of node18.
Active support for Node 16 ended in Oct 2022. Security support ends one month from now.
by the looks of it, there's not a whole lot of movement towards 6.0 here, so i'll mention that i just published v0.5.0 of https://github.com/leeoniya/uDSV which some may find interesting.
the performance i'm seeing in Linux / Node v20.5.1 is 1x-5x faster than Papa Parse, with 2.5x being typical.
i spent entirely too long on getting the benchmarks right, and i believe their scope is the most thorough in breadth and depth: https://github.com/leeoniya/uDSV/tree/main/bench.
feedback and corrections/criticism is welcome :)
Would love to get your feedback on my wishlist for Papaparse. We're going to dedicate some time for the team @ Flatfile before the end of year to move anything on this list we're agreed on to a next release.
1. Migrate to ES7 + Typescript or Flow
This is something that, after a deep audit of the source code we feel is necessary to ensure long term reliability. In a data oriented library like this, type strength will allow for easier reasoning about the code, add stability and prevent unseen bugs. ES7 will allow for more readable code
2. Separate NodeJS build from Browser build
This will allow for a lighter package when using in the browser (vast majority based on cursory analysis), as well as open more freedom to invest in optimizations for each stack independently. These could either be distributed as different packages (eg.
@papaparse/core
and@papaparse/node
) or a second build in the same package. (eg. (import PapaParse from 'papaparse/node'
)3. Reduce core sugar and add plugin framework
We've noticed a lot of the open issues relate to desired support of edge cases or unique data scenarios that shouldn't be treated as part of the core "csv parser" but are entirely legitimate use cases. The goal here is to distribute a core package with common functionality and allow users to choose additional use cases as needed.
Candidates:
@papaparse/http
- adapter for downloading or streaming data from web - can be optimized separately for nodejs and browser as well as opens up for other adapters for things like S3 with plenty of optimizations.@papaparse/types
- split out the typecasting logic, there's a lot of room for improvement here w/better understanding of boolean types, dates, etc. But it doesn't make sense to invest that into a core csv parser library.@papaparse/unparse
- there's been a decent amount of confusion with users about how different configurations relate to parse vs. unparse. These are also distinctly different problems to solve for.Future Candidates: Things like
detect-encoding
to auto detect file encoding,generous-escaping
(for the common unescaped quotes situation), and many other user requests. Additionally framework specific components like an HoC for React could be awesome.4. Improved docs
Would love to see updated searchable docs with both auto generated API references as well as guides, fiddles, and improved demo. I'm a fan of docusaurus for this. We'd be happy to contribute content & design here.
5. Reorganized source code
With almost 2000 lines in papaparse.js it's time to tackle deconstructing that a bit into components that are easier to reason about. Since 4b16215353aa256da44c48160441e91ef0254340 6 years ago (335 lines) when most of the tools we have at our disposal today weren't available, we haven't changed much. Time for a
src
folder! Let's follow https://sourcemaking.com/refactoring as a guide6. Tests, coverage, cross-browser testing & CI based distribution
We should take advantage of setting up the Sauce testing matrix so we don't break things in old browsers as we go. Also, it'd be great if we could use Github Actions to auto deploy master and release candidates to npm / bower / etc. In addition we should improve unit test coverage in addition to the mainly acceptance testing we have now.
7. Other: Pipes, Promises, etc.
8. Backwards compatibility adapter
Because this would be a pretty robust overhaul, we should publish an adapter that's fully backwards compatible with re-composed elements. Possibly
@papaparse/legacy
- allowing people to move forwards without a complete overhaul. It could also identify the things they aren't using and give them a custom migration checklist.We're happy to take on the work of this overhaul here at Flatfile - so keep in mind we're not asking for a lot of work from the community. But do please provide feedback on all of this, we want to chart a path forwards that makes sense to everybody.
Also, what do you want to see? Comment with new ideas or criticisms / approval of the above.