search

mholt / acmez

Premier ACME client library for Go
https://pkg.go.dev/github.com/mholt/acmez/v2
Apache License 2.0
281 stars 35 forks source link

More time for success? #5

Closed codewinch closed 3 years ago

codewinch commented 3 years ago

In https://github.com/mholt/acmez/blob/master/client.go#L114 , does that mean that it will only wait 1 second for LetsEncrypt to respond?

We have sometimes waited for 10 or 20 seconds. :( Can we send a pull request to change that one line, or am I misunderstanding that line?

Thanks for an awesome lib!

mholt commented 3 years ago

No, that line just waits 1 second between retries.

FYI, most Go programmers will actually want to use CertMagic to automate certificates because this library does not keep them renewed (and since certificates expire, simply getting them without renewing them is not very useful).

Thanks for an awesome lib!

You're welcome :+1: