Prevent retry when remainingChallenges is empty

mholt / acmez

Premier ACME client library for Go

https://pkg.go.dev/github.com/mholt/acmez/v2

Apache License 2.0

272 stars 32 forks source link

Prevent retry when remainingChallenges is empty #8

Closed n0cloud closed 2 years ago

n0cloud commented 2 years ago

After an error, check if it's possible to retry before returning an retryableErr. That way it return the real error instead of returning "no solvers available for remaining challenges".

It wasn't my intention, but I think it'll solve #7

mholt commented 2 years ago

Hi, thanks for opening this PR!

I'll try to take a look at it soon. Have you tested to see if it does resolve #7? I haven't gotten a reply about how to reproduce the behavior yet.

n0cloud commented 2 years ago

I can't confirm 100% it's the same issue, but I was having similar logs. You can disable one or two of the ChallengeSolvers in the porcelain example to get similar logs.

Got some time to test correctly so I updated the PR

mholt commented 2 years ago

Thanks for verifying and patching; and for the repro instructions. I'll look into this more soon!