Add lzip support - Githubissues

mholt / archiver

DEPRECATED. Please use mholt/archives instead.

https://github.com/mholt/archives

MIT License

4.45k stars 392 forks source link

Closed sorairolake closed 7 months ago

sorairolake commented 7 months ago

Closes #400

mholt commented 7 months ago

Nice, thank you! This is looking good. Will merge this shortly. Appreciate your contribution!

mholt commented 7 months ago

Hm, lz4 compression with extension is failing. @sorairolake Does it fail for you locally?

sorairolake commented 7 months ago

@mholt Just now, I ran the test locally 10 times, 8 passed but 2 failed. I don't know why the test sometimes fails.

mholt commented 7 months ago

Hmm, sounds like something funky with the test suite. I'll look into it, but your change seems sound.

sorairolake commented 7 months ago

Both lz4 and lzip starts with "lz". So I think this may be related.

mholt commented 7 months ago

PS. I hope to travel to Japan someday :D