mholt / caddy-ratelimit

HTTP rate limiting module for Caddy 2
Apache License 2.0
254 stars 17 forks source link

Fix not enough arguments #8

Closed sylloger closed 2 years ago

sylloger commented 2 years ago

Close #7

francislavoie commented 2 years ago

Ah, yeah. That's due to https://github.com/caddyserver/certmagic/pull/155, so this plugin stopped being compatible with the latest version of Caddy.

Thanks for the fix!

francislavoie commented 2 years ago

I think the go.mod should be updated as well, probably, since it now targets a newer version of certmagic and Caddy by making these changes.

mholt commented 2 years ago

That's weird. 🤔 I believe go.mod will also need to be updated to the latest versions of CertMagic / Caddy, as currently this change is not compatible with the pinned versions.

sylloger commented 2 years ago

@francislavoie @mholt Thank you for bringing this to my attention. I ran into the error while compiling in xcaddy, I didn't realize I needed to update go.mod at the time, I've since updated it.

Please let me know if you require any other changes.