mholt / caddy-webdav

WebDAV handler module for Caddy
Apache License 2.0
228 stars 24 forks source link

Revert dependency upgrades #43

Closed francislavoie closed 6 months ago

francislavoie commented 6 months ago

This reverts commits:

Fixes #42 and https://github.com/caddyserver/caddy/pull/6318#issuecomment-2121836814

We should never upgrade dependencies of Caddy plugins like this, unless we're specifically needing to update direct dependencies for a specific reason. All it does is break compatibility with older Go or Caddy versions without any benefit. xcaddy takes care of solving for the dependencies when adding the plugin modules based on the targetted Caddy version.

EdenSpire commented 6 months ago

Thanks guys.

mholt commented 6 months ago

VS Code was the culprit for at least a few of those, I'm not sure why it thought that was a good idea, but I didn't notice the Go version upgrades. I only meant to upgrade a few of the dependencies that had those stupid "security vulnerability" scanners popping up false positives.