search

mholt / photobak

Back up your content from Google Photos - DEPRECATED: use Timeliner
https://github.com/mholt/timeliner
307 stars 29 forks source link

Handling duplicated file names #12

Closed jkl1337 closed 5 years ago

jkl1337 commented 7 years ago

It looks like this is not dealing too well with photos with the same name. Hangouts apparently saved images from the same day with the same name (just the date) and the tool doesn't rename these duplicates. Every time the command is rerun of course it detects it as a checksum error and redownloads.

mholt commented 7 years ago

Hmm, that doesn't sound right; we use the item's ID, not its filename, to distinguish duplicates: https://github.com/mholt/photobak/blob/84180cea804f357c6bb007fa9602f83ca209cafb/googlephotos/xmlstruct.go#L110

Maybe the file is not downloading correctly instead?

jkl1337 commented 7 years ago

Ah fair enough. I didn't actually debug the problem (due to lack of time right now). The images were all from hangouts a few years ago, and demonstrate the repeating name pattern (and there is ultimately only one file left in the directory). I'll see if I can look into it more later.

mholt commented 7 years ago

I've experienced something similar on a few of my photos (not Hangouts ones, although I have several of those) and am not sure if a recent PR may have fixed it. Haven't looked into it too much recently.

mholt commented 5 years ago

This project has been deprecated in favor of Timeliner. Thank you!