search

mholtzscher / syllapy

Calculate syllable count for English words.
MIT License
34 stars 9 forks source link

Add an API method to supplement the preloaded dict with additional explicit syllable counts? #87

Open harrisj opened 4 years ago

harrisj commented 4 years ago

As I mentioned, I am running a haiku finding bot against the New York Times so I keep finding new exceptions to be added to the list (for instance, I think today there was "falsehoods" and "reconciliation"). Although my intention is to make regular pull requests with syllable changes, I would like to supplement the load_dict method with another method I can call to supplement syllapy's exceptions with my own JSON (or CSV if you decide that approach is okay). This way I can make immediate and incremental patches to behavior on my end and then roll up into larger regular PRs

harrisj commented 4 years ago

If you want me to implement and do a PR for this, let me know, but I will also wait for you to make an assessment on whether you prefer JSON or CSV first. Thanks!

mholtzscher commented 4 years ago

I have an idea for how to handle this. I'll tag you on the PR when I get it out

harrisj commented 4 years ago

Thank you! I wound up monkey-patching it, but definitely will switch to a more elegant solution