Closed mhostetter closed 1 year ago
Base: 96.40% // Head: 96.48% // Increases project coverage by +0.07%
:tada:
Coverage data is based on head (
b436e61
) compared to base (0fa9721
). Patch coverage: 98.61% of modified lines in pull request are covered.:exclamation: Current head b436e61 differs from pull request most recent head 84f2a73. Consider uploading reports for the commit 84f2a73 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@iyanmv just tagging you here in case you wanted to review this. I'm thinking of merging this onto release/0.3.x
. I believe it should not conflict with your branch when rebasing.
If you have any thoughts or concerns, we can address them before I merge.
Oh, wow! Nice! I now understand all those @functools.lru_cache(maxsize=8192)
in the code 😄 . I will not have time to review this properly, unfortunately, so don't wait for me to merge.
Poly
methods into a more logical module-based structure.@method_of(SomeClass)
decorator to monkey-patch a function from a different file into a method of the specified class. This helps avoid God classes, with slight additional obscurity.Poly.is_irreducible()
.Poly.is_primitive()
.The memoization overhead doesn't hurt for small polynomials, but really helps for large polynomials.
Before
After