search

mhostetter / galois

A performant NumPy extension for Galois fields and their applications
https://mhostetter.github.io/galois/
MIT License
321 stars 29 forks source link

Check for and handle None docstrings #545

Closed jcharlong closed 3 months ago

jcharlong commented 4 months ago

This PR addresses https://github.com/mhostetter/galois/issues/544

I confirmed that I ran into the issue by running tests w/ python -OO -m pytest tests/. The issue is resolved & all tests completed after this update.

Let me know if there are any version or release notes I should be handling in this PR. I could not find any guidelines on this for developers in the repository's documentation.

mhostetter commented 4 months ago

Can you rebase this off of mhostetter:release/0.3.x? That is required to pass the tests.

jcharlong commented 4 months ago

Sure thing, just pushed after rebasing.

mhostetter commented 3 months ago

The latest macos CI runners have screwed things. I've got to debug this before the tests can work. Hang tight.

mhostetter commented 3 months ago

Can you rebase off of release/0.3.x again? (I would do it, but I don't know how for you branch.) I think we should be good now.

jcharlong commented 3 months ago

Sure thing, just pushed after rebasing. Thanks for your quick turn around time in debugging, I appreciate it.

mhostetter commented 3 months ago

Thanks! I'll push a new release tonight.

jcharlong commented 3 months ago

Great, thanks again for the quick support.