Bump to 3.10/3.11 - Githubissues

mhostetter / gr-adsb

GNU Radio OOT module for demodulating and decoding ADS-B packets

GNU General Public License v3.0

147 stars 44 forks source link

Bump to 3.10/3.11 #48

Closed bkerler closed 11 months ago

bkerler commented 2 years ago

Update module to gnuradio 3.10/3.11

mhostetter commented 2 years ago

Thanks for this!

It's been a while since I used GNU Radio. A couple questions:

Are OOT modules for GR 3.10 and 3.11 interchangeable? I'm guessing this should get merged onto maint-3.10 and we can advertise support for both versions?
Do you know if the maint-3.8 branch worked for GR 3.8 and 3.9?
How did you make these changes? With a scripted conversion tool?

Again, thanks.

mhostetter commented 2 years ago

@bkerler did you happen to see my questions above?

bkerler commented 2 years ago

Hi, yes works with 3.10 and 3.11. No, haven't tested the 3.8 version. The 3.8 version won't work with 3.9 due to pybind being used instead of swig. I didn't use any conversion script but did it all manually from scratch.

mhostetter commented 11 months ago

@bkerler sorry for the delay in getting around to this. I hesitated because my environments weren't set up to test this manually. I appreciate the contribution. 🙏

bkerler commented 11 months ago

No worries, thanks 👍