search

mhostetter / nhl

A Python 3 API for NHL game and player stats
https://nhl.readthedocs.io/en/latest/
MIT License
26 stars 5 forks source link

Fetch Shifts function still active? #3

Open jantznick opened 3 years ago

jantznick commented 3 years ago

https://github.com/mhostetter/nhl/blob/8ab4150686665f44bf8108a8ff49b778e0357d31/nhl/statsapi/parse.py#L22

I am doingsome parsing of the API, notice most in this library is pretty standard, but you seem to have come across a shifts html page of some sort. Curious if this page is still a live page and if you have an example of it? I can't seem to generate one myself.

Great work on this library by the way!

mhostetter commented 3 years ago

Sorry for the late reply! Hmmm... maybe it is inactive. I just tried to open an example "htmlreports" page for game_id = 2017030415. The URL (manually constructed, like done in the _fetch_shifts() function) is https://www.nhl.com/scores/htmlreports/20172018/TV030415.HTM, but that doesn't seem to load. I thought I heard rumblings on the internet that the API was going to change some this season. Maybe this is one consequence. I haven't been using/developing this repo recently enough to know when the change happened.

Let me keep looking into this, but thanks for bringing it to my attention.