mhotan / DineOn

Git Repository for our 403(13sp) Android application "DineOn"
0 stars 0 forks source link

Adds more library tests #314

Closed glee23 closed 11 years ago

glee23 commented 11 years ago

Removing in the DineOnUser class doesn't work -- for instance, I call add(item), and it adds it, but when I then call remove(item), it doesn't remove it, and contains(item) returns false.

I'm thinking it's because equals isn't working right, and this might be why we can't remove objects from the cloud

mhotan commented 11 years ago

Nice!

mhotan commented 11 years ago

Did you save the objects before hand? Because of they aren't saved equals will be false

On Friday, May 31, 2013, glee23 wrote:

Removing in the DineOnUser class doesn't work -- for instance, I call add(item), and it adds it, but when I then call remove(item), it doesn't remove it, and contains(item) returns false.

I'm thinking it's because equals isn't working right, and this might be

why we can't remove objects from the cloud

You can merge this Pull Request by running

git pull https://github.com/glee23/DineOn master

Or view, comment on, or merge it at:

https://github.com/blasv/DineOn/pull/314 Commit Summary

  • Adds more library tests

File Changes

  • A DineOnLibrary/tests/src/uw/cse/dineon/library/test/CredentialValidatorTest.javahttps://github.com/blasv/DineOn/pull/314/files#diff-0(448)
  • D DineOnLibrary/tests/src/uw/cse/dineon/library/test/MenuItemTest.javahttps://github.com/blasv/DineOn/pull/314/files#diff-1(37)
  • A DineOnRestaurantApplication/tests/src/uw/cse/dineon/library/test/DineOnUserTest.javahttps://github.com/blasv/DineOn/pull/314/files#diff-2(157)

Patch Links:

Michael Hotan