mapview to leaflet

[joyliujoyliu]

Fig 7 uses leaflet now, 2 legends, mouse-click popups with PI, detections, individuals, station name, detected by

[mhpob]

Pinging both @joyliujoyliu and @jdpye for tracking purposes.

Can I ask you to move your code into a new function within the R/ directory, and then call that function within the QMD template? A few reasons why I ask for this:

• Files in inst/ are not compiled when an R package is built, just copied as-is. Because of this, R does not register packages listed in the inst/.*qmd as used by otndo; nstalling otndo will not install these dependencies.
  • R CMD check will throw a warning even if you list these dependencies in DESCRIPTION (which should be done), as it can't look inside files in inst/ and doesn't see that the package is using the dependency.
• We can write unit tests for the function, which we can't do if it's hidden within the QMD.
• We can more-easily find and fix bugs that emerge since R will highlight the individual function that broke, as opposed to saying "something went wrong somewhere while trying to knit the document"

Additionally, I ask you to hunt down what in your code is causing my current unit tests to fail and fix that. Hint: it's related to the dependency issue noted above.

Optimally, I would also ask that:

• you document the resulting function using roxygen comments and run the necessary code to build the docs (devtools::document());
• similar adjustments are made to inst/make_receiver_push_summary.qmd since I try to make development of these reports move in parallel (this should be simple once you make a function -- you can just paste the function into inst/make_receiver_push_summary.qmd); and
• you create unit tests of your newly-created functions to make sure they're behaving as you expect them to.

[joyliujoyliu]

leaflet_graph.R