search

mhrivnak / radiotherm

python client library for Radio Thermostat wifi-enabled home thermostats
BSD 3-Clause "New" or "Revised" License
50 stars 40 forks source link

Handle the API transient error condition(-1) #24

Closed tubaman closed 5 years ago

tubaman commented 7 years ago

The API developer guide in section 2.7.3 states that tmode and/or temp could return a -1 in the case of a transient error within the thermostat. Today these values get returned as-is. We should instead handle these by raising an exception.

tubaman commented 7 years ago

Here's a PR: https://github.com/mhrivnak/radiotherm/pull/25

tubaman commented 7 years ago

Note: I've seen these transient errors in the field via home assistant.

tubaman commented 6 years ago

@mhrivnak, any thoughts on this?

craftyguy commented 6 years ago

According to @TD22057's comment on that PR, this may cause issues for home assistant, since they apparently rely on this library returning -1 when there are issues.

craftyguy commented 5 years ago

The relevant PR has been merged, I will submit changes for homeassistant when I make a new release here.