search

mhrivnak / radiotherm

python client library for Radio Thermostat wifi-enabled home thermostats
BSD 3-Clause "New" or "Revised" License
49 stars 40 forks source link

Add support for CT80 Rev B2 V1.00 #29

Closed craftyguy closed 6 years ago

craftyguy commented 6 years ago

LGTM, but I submitted it :stuck_out_tongue:

I have to apply this patch every time I test other patches. Hopefully someone else can ACK it if they have this device, but I would really appreciate it being merged if that's not the case, since it really does work for me after testing it a LOT :smiley:

TD22057 commented 6 years ago

Looks fine to me. It seems pretty cumbersome to have to keep adding model revs though when nothing is actually different. I'm going to open an issue to allow get_thermostat to just return a CT80 or if "Rev B" is in model, return a RevB instance.

craftyguy commented 6 years ago

That's a great idea. Yea adding each tiny variation is cumbersome and probably not worth it if there are no functional differences between them