search

mhrivnak / radiotherm

python client library for Radio Thermostat wifi-enabled home thermostats
BSD 3-Clause "New" or "Revised" License
49 stars 40 forks source link

Allow unknown thermostats to work instead of failing silently. #37

Closed JerryWorkman closed 6 years ago

JerryWorkman commented 6 years ago

Allow unknown thermostats to work instead of failing silently.

Based on fork of 1.2

craftyguy commented 6 years ago

Great! Do you plan to rebase this to the master branch, or shall I?

JerryWorkman commented 6 years ago

I don't have the time now.

You have my blessings. I shouldn't take long and will make all of the Home Assistant users happy.

On Sat, Jun 23, 2018 at 9:52 PM clayton craft notifications@github.com wrote:

Great! Do you plan to rebase this to the master branch, or shall I?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mhrivnak/radiotherm/pull/37#issuecomment-399722675, or mute the thread https://github.com/notifications/unsubscribe-auth/ABsbQPXjgZxiZEXbsWQhHDC7YTC3iIEhks5t_vDkgaJpZM4U09bG .

craftyguy commented 6 years ago

Sounds good, I'll take a look at it then. Thanks for your help!

craftyguy commented 6 years ago

@JerryWorkman I didn't want to push to your master branch to update this PR, so I created a new branch and new PR (#38), and will close this one. You're still the author of one commit to that branch, so I would appreciate it if you could look it over before I merge it :)

Thanks for the help, I really appreciate it!