search

mhsabbagh / green-recorder

A simple screen recorder for Linux desktop. Supports Wayland & Xorg
GNU General Public License v3.0
616 stars 118 forks source link

Stop button is not working #121

Closed vbarbarosh closed 5 years ago

vbarbarosh commented 5 years ago

After start recording the only way to stop is to close application. Clicking on stop button has no effect.

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.1 LTS
Release:    18.04
Codename:   bionic

Version of green-recorder is 3.2. I tried to open it from terminal. This is what I get by clicking on stop button:

TypeError: stoprecording() takes exactly 1 argument (0 given)
Traceback (most recent call last):
  File "/usr/bin/green-recorder", line 484, in stoprecordingclicked
    stoprecording()
mhsabbagh commented 5 years ago

This sounds like an issue from the code indeed and I'll fix it soon. But it's not the only way to stop recording; You can stop recording using the system tray icon.

vbarbarosh commented 5 years ago

I fixed it by changing

def stoprecording(_):

to

def stoprecording():

Concerning your recommendation of using system tray icon - I didn't have it. So, closing green-recorder was the only option for me.

https://i.ibb.co/2P17HBv/Screenshot-from-2019-02-09-14-57-38.png

Btw, thanks for the app.

mhsabbagh commented 5 years ago

Fixed in 3.2.1