search

mhsabbagh / green-recorder

A simple screen recorder for Linux desktop. Supports Wayland & Xorg
GNU General Public License v3.0
616 stars 118 forks source link

Add mkv/ogg pipeline #71

Closed yucefsourani closed 6 years ago

yucefsourani commented 6 years ago

Add mkv/ogg pipeline for gnome wayland

mhsabbagh commented 6 years ago

Those pipelines didn't work with me when I tested them on GNOME 3.26.

yucefsourani commented 6 years ago

i think ogg(theoraenc,oggmux) need gst-plugins-base && mkv(x264enc,matroskamux) need gst-plugins-ugly gst-plugins-good gst-plugins-base

https://gstreamer.freedesktop.org/documentation/plugins.html

mhsabbagh commented 6 years ago

Well, you should have done the testing before submitting the pull request, we can't include something which needs an extra dependency in the program without specifically requiring it.

Please test your pull request on GNOME 3.24 & 3.26 and make sure of the results.