search

mhsabbagh / green-recorder

A simple screen recorder for Linux desktop. Supports Wayland & Xorg
GNU General Public License v3.0
616 stars 118 forks source link

fedora 28 and rawhide package #94

Open crunchy-github opened 6 years ago

crunchy-github commented 6 years ago

Hi,

I would really appreciate it if you could build a package for fedora 28. I already tried to rebuild the old source rpm, but there are at least two problems

crunchy-github commented 6 years ago

Ok fedora 28 did not really switch to python 3 (read some wrong information). But still I get an error message when starting green recorder regarding dbus

[rpmbuild]$ green-recorder Traceback (most recent call last): File "/usr/bin/green-recorder", line 23, in from pydbus import SessionBus ImportError: No module named pydbus

mhsabbagh commented 6 years ago

Well, it seems as that Fedora no longer provides python2-pydbus package in the new versions, which is sad because this is a dependency for our program.

We'll need to package it manually and upload it to our repository, but sadly I am very busy.

sustmi commented 6 years ago

As a workaround you can install manually install the python2-pybus rpm for Fedora 27: https://dl.fedoraproject.org/pub/fedora/linux/releases/27/Everything/x86_64/os/Packages/p/python2-pydbus-0.6.0-3.fc27.noarch.rpm It works for me on Fedora 28.

probonopd commented 6 years ago

Does not work in Rawhide:

[root@localhost-live ~]# sudo rpm -ivh /home/liveuser/Downloads/python2-pydbus-0.6.0-3.fc27.noarch.rpm 
warning: /home/liveuser/Downloads/python2-pydbus-0.6.0-3.fc27.noarch.rpm: Header V3 RSA/SHA256 Signature, key ID f5282ee4: NOKEY
error: Failed dependencies:
    python-gobject-base is needed by python2-pydbus-0.6.0-3.fc27.noarch
sallyhaj commented 6 years ago

It is still working with me on F28, because I've upgraded from f27, so I have python2-pydbus, but with my friend fresh installation, it's not working as you said. @mhsabbagh Does the app need an upgrade to python3 in general or just re-packaging as you mentioned?

hetzbh commented 6 years ago

@probonopd don't use directly the rpm command. Use the dnf command with your local RPM that you downloaded on fedora and it will auto install the dependencies from the repositories.

mhsabbagh commented 6 years ago

It sounds like the python2-pydbus package is now available for both Rawhide and F28. I have added the package repo to the readme file.

nirix commented 6 years ago

@mhsabbagh the install on Fedora 28 fails due to a missing package as mentioned here: https://github.com/foss-project/green-recorder/commit/c8d9b521f44353e00a05d7f8548edb73074938d6#commitcomment-30670360

Last metadata expiration check: 0:00:56 ago on Tue 02 Oct 2018 09:20:19 AEST.
Error: 
 Problem: conflicting requests
  - nothing provides python2-pydbus needed by green-recorder-3.1-75.1.noarch
mirkancal commented 5 years ago

I've installed with dnf install python2-dbus and sudo pip install pydbus but still have that nothing provides python2-pydbus message.

sallyhaj commented 5 years ago

I've installed with dnf install python2-dbus and sudo pip install pydbus but still have that nothing provides python2-pydbus message.

I suggest you to remove pydbus then just install the one from fedora, you can find a package dnf install http://fedora.c3sl.ufpr.br/linux/releases/28/Everything/x86_64/os/Packages/p/python2-dbus-1.2.4-13.fc28.x86_64.rpm It's working with me with this package

mhsabbagh commented 5 years ago

My bad, it seems that the available package is python2-dbus, not python2-pydbus, which is different. I'll have no option but to upload that package to our repository and build it there then.

aappddeevv commented 5 years ago

I did an install by downloading the rpm file and using rpm --nodeps. I had to install the python dependencies using pip install first though. However, it seems to error out after stopping recording. I am running wayland.

Update: It is working. Not sure why it did not work before, perhaps a reboot was necessary.

byteSamurai commented 5 years ago

@mhsabbagh Maybe its a good idea to use flatpak here? I haven't done anything with it, but at least it looks, like it might be no big deal and would solve the problem, won't it?

See also: http://docs.flatpak.org/en/latest/python.html

mhsabbagh commented 5 years ago

@byteSamurai We have an issue in the code which prevents it from being packaged as a Flatpak. aka #7

probonopd commented 5 years ago

At least for me it would not solve the problem because I am running Fedora from the Live ISO and Flatpak doesn't seem to handle this.

mhsabbagh commented 5 years ago

I have built the python-pydbus package locally on our repository. Fedora 28 and Rawhide should work now. Please test and let me know. (Just run dnf update, and then dnf install green-recorder).

As for Fedora 29, openSUSE Build Service (which is what we use to build packages) doesn't support it yet. So you'll have to wait until they do.

sebix commented 5 years ago

As for Fedora 29, openSUSE Build Service (which is what we use to build packages) doesn't support it yet. So you'll have to wait until they do.

They do (at least now) https://build.opensuse.org/project/show/Fedora:29

mhsabbagh commented 5 years ago

As for Fedora 29, openSUSE Build Service (which is what we use to build packages) doesn't support it yet. So you'll have to wait until they do.

They do (at least now) https://build.opensuse.org/project/show/Fedora:29

Thanks. This indeed news, I have released the package for Fedora 29.