mhsabbagh / green-recorder

A simple screen recorder for Linux desktop. Supports Wayland & Xorg
GNU General Public License v3.0
616 stars 118 forks source link

Add Support for Python 3 #97

Closed ghost closed 5 years ago

ghost commented 6 years ago

I've changed the program where it failed to work with Python 3, because I had some difficulties trying to package it with Python 2 as Flatpak, the script also makes some assumptions about the installation prefix, but Flatpak requires a different structure than here provided, hence I've fixed it also. I haven't found a nice method for determining the prefix in every case, but that should work for pretty much 99% of the use-cases.

top-sekret commented 5 years ago

I really support your installation prefix patch. Thus, it will be possible to install GR in /usr/local or somewhere.

McSinyx commented 5 years ago

However, this will remove support for Python 2. Backward incompatibility has never been a good thing.

mhsabbagh commented 5 years ago

As the friend above said, this will force the program to use Python 3 which isn't something I would like to do at the moment. Many distributions still have /usr/bin/python redirected to Python 2, so losing that isn't good.

As for Flatpak, I personally have no intention to support it. I have also removed the Snap. We have repositories on most major distributions and I don't like to invest in these technologies, for now. Still, I agree we need to detect the correct installation prefix instead of just using /usr/share.