search

mhtghn / Luricifer

A simple CLI tool to fetch lyrics from AZlyrics of the playing Spotify song
MIT License
21 stars 3 forks source link

Pip azlyrics instead of copying the module #5

Closed ramonsaraiva closed 6 years ago

ramonsaraiva commented 6 years ago

Closes https://github.com/mhtghn/Luricifer/issues/4

mhtghn commented 6 years ago

Oh hi dear Guru :). PR merged thx. Ive been working on the synced lyrics. I dunno if you have tried it. If so what do you think about the way I did it? And if you have any recommendations, I'll take them

ramonsaraiva commented 6 years ago

Not even close to a guru, but i've checked that you changed the parameter, not sure how the functionality works currently, but i saw that whenever i used that parameter my song restarted and the synced dir was created with some information about the times of the lyrics.

I'll look at the implementation later.

mhtghn commented 6 years ago

The first time you listen to a song, you can use the --sync parameter to sync the lyrics to the song. The song restarts because that's the only way for me to know the time position of the song playing (for example 3:04/5:20), the Spotify dbus Position property always returns 0. Then the next time you listen to the same song, there's no need to use the --sync parameter: the lyrics will be displayed at same frequency you displayed them the first time (no need to press Enter no more).