search

mhthies / knxdclient

A pure Python async client for KNXd's (EIBd's) native Layer 4 KNX protocol.
Apache License 2.0
12 stars 3 forks source link

Fix Example Readme #1

Closed simongregorebner closed 2 years ago

simongregorebner commented 2 years ago
mhthies commented 2 years ago

Hi, thanks for your contribution! :)

Considering the asyncio.run() method, I agree with your change.

For the imports, I actually would like to keep the original version: All elements of the "public API" of this library are re-exported by the knxdclient module itself (via the __init__.py file) and its more like an implementation detailt, that they are spread over different modules inside the package.

simongregorebner commented 2 years ago

Sorry, for some reasons I missed the imports in the __init__.py ... and I thought you intentionally restructured the package and require the explicit imports from the different submodules. Sure this way the import changes doesn't make sense! Probably best you drop this pull request and simply fix the asyncio.run()

mhthies commented 2 years ago

I noticed that there were actually classes missing in the re-exports, which have been required for the type annotations in the example. I fixed this on the master branch now and included your fix for the run() method.