Add curl jsonlite for bing and google

mhudecheck / revgeo

Reverse Geocoding in R with Google Maps API and Photon API

GNU General Public License v3.0

23 stars 7 forks source link

Add curl jsonlite for bing and google #5

Closed timetheoretical closed 5 years ago

timetheoretical commented 5 years ago

I have now implemented the curl and jsonlite solutions for the bing and google APIs, improved the error handling in the async download, and updated the documentation. Let me know if it works for you and if you think anything should be modified.

mhudecheck commented 5 years ago

Merged! : )

timetheoretical commented 5 years ago

Great! :) Would you mind testing the three APIs (I have tested them on windows and linux, but it is always useful that someone else try it)?

Also, what would be the next steps for pushing it to CRAN?

mhudecheck commented 5 years ago

I'll try to push the changes to CRAN later this week. I have a couple edits of my own that I want to finish up first (they'll hopefully be done in a couple of days).

timetheoretical commented 5 years ago

Okay, sounds good.