search

mhuebert / shadow-re-frame

Example of shadow-cljs with re-frame, re-frame-trace
55 stars 15 forks source link

Use absolute path for resource files #1

Closed kurtharriger closed 6 years ago

kurtharriger commented 6 years ago

Consider using absolute path instead of relative in index.html

See https://github.com/thheller/shadow-cljs/issues/176

mhuebert commented 6 years ago

Hi Kurt,

Thanks for the PR. I normally do use absolute paths (and for the same reason, so that pushstate routes work), but this example is hosted via github pages at a subpath - https://mhuebert.github.io/shadow-re-frame/ - so I think an absolute /js... path would break there, while adding /shadow-re-frame/js as the path would be broken locally.

kurtharriger commented 6 years ago

I used this as a starter project and probably will again, but if its intentional that is good to know. Thanks.

mhuebert commented 6 years ago

That's a valid use case. We could at least add a comment somewhere about this, & maybe look at a different way of hosting. -- http://matt.is — Berlin, Germany