search

mhuggins / dogeify

Ruby gem for converting English to Doge.
MIT License
28 stars 5 forks source link

plz no, wow, amaze, excite #1

Closed jomo closed 10 years ago

jomo commented 10 years ago

adds more last words (randomly picked) if the text contains xxxn't or not it will end with "plz no"

mhuggins commented 10 years ago

Thanks! I'm going to wait to pull this in because I built it for a simple presentation, but I will in about a week. :)

jomo commented 10 years ago

nice :+1:

mhuggins commented 10 years ago

I don't have Travis CI set up on this repo yet, but your change actually breaks the rspec tests. Would you mind updating broken tests & adding a test for your change? If not, I'll just plan on doing so after I pull it in prior to releasing an update. Thanks!

mhuggins commented 10 years ago

Closing this since other changes enabled wow, amaze, and excite. Please reopen if you think there's anything else that's needed. :)