search

mhujer / BreadcrumbsBundle

Breadcrumbs bundle for Symfony. This is a fork of whiteoctober/BreadcrumbsBundle maintained for newer Symfony and PHP versions.
Other
66 stars 12 forks source link

Removed deprecated twig tags #40

Closed basdenooijer closed 2 months ago

basdenooijer commented 2 months ago

Related to https://github.com/mhujer/BreadcrumbsBundle/issues/39

mhujer commented 2 months ago

@basdenooijer Hello, thanks for the PR!

Can you please also adjust the tests in https://github.com/mhujer/BreadcrumbsBundle/blob/master/Test/BundleTest.php? You can run them locally with vendor/bin/phpunit. I think it would make sense to use nowdoc for the expected output.

basdenooijer commented 2 months ago

Sure, I was a bit in rush with the fix so completely missed the tests. Just pushed an update.

Shortly looked into comparing the HTML independent of the whitespace in the template, but there doesn't seem to be an easy way to do this. Introducing a (dev) dependency just for this seemed overkill.

mhujer commented 2 months ago

@basdenooijer Thank you! Merged and tagged as 1.5.10

basdenooijer commented 2 months ago

Great 👍