Closed feldsam closed 4 months ago
@feldsam Hi, thanks for the PR! I'm not sure that including the certificate in the repo still makes sense. Maybe it would be better if it depended on composer/ca-bundle
directly? What do you think?
//cc @soukicz ?
There is actually dep on \Kdyby\CurlCaBundle\CertificateHelper, but there is also fallback, if this is not installed. So I just updated fallback cert.
But, it makes sense move suggest dep to required dep and drop fallback
I'm not sure that including the certificate in the repo still makes sense
It is nice that it can run without dependencies. And it is just fallback because it is already using composer/ca-bundle if it is available.
There is still guzzlehttp/guzzle
dep and I think, that it is better to use ca-bundle instead of maintaining cert in repo as @mhujer pointed.
So I updated my commit to remove fallback and cert from repo and refactored code to use ca-bundle only
@feldsam thanks! merged and tagged as 5.0.0
Hi, on some systems I was getting error
and I figured out, that shipped certificate have to be updated