search

mhulden / foma

Automatically exported from code.google.com/p/foma
117 stars 90 forks source link

Modify bison files to require minimum version #128

Open dowobeha opened 3 years ago

dowobeha commented 3 years ago

On macOS, bison is present but is an ancient version. On macOS 10.15.7, the version of bison is 2.3.

As a result, some of the newer fixes to bison files use syntax that bison 2.3 doesn't recognize, resulting in bison syntax errors.

Bison supports marking a minimum required version.

There are two options. One is rewriting the bison files to support bison 2.3 syntax. While this would be nice for those of us on macOS, a simpler solution would be to use the bison require syntax to require a specific version of bison.

AmbientLighter commented 3 years ago

Hi, Package for macOS is built without errors on macOS 10.15.7 Here's log: https://github.com/mhulden/foma/runs/2773115543 and ZIP archive: https://github.com/mhulden/foma/suites/2939992105/artifacts/66053844

pemistahl commented 3 years ago

@dowobeha is right. Foma builds on macOS in your CI pipeline only because the most current version of bison is installed via Homebrew.

@AmbientLighter Can't you just extend your CI pipeline to put the compiled binaries as attachments on a tagged release? It would be really helpful if you created tagged releases when you finish a new version. This way, users would not have to compile from source themselves.

AmbientLighter commented 3 years ago

@pemistahl I'm not a maintainer of foma, so I've asked @mhulden to tag releases or grant me a permissions. See also: https://github.com/mhulden/foma/issues/93 Unfortunately, he didn't respond to any comments or requests. Surely, I can tag releases in my own fork, but I'm not really sure whether it would do more harm than good.

AmbientLighter commented 3 years ago

See also: https://github.com/AmbientLighter/foma/releases/tag/0.10.0

pemistahl commented 3 years ago

Fair enough, @AmbientLighter. Thank you for the compiled binaries.