search

mhulden / foma

Automatically exported from code.google.com/p/foma
115 stars 90 forks source link

Fix CMake build failing on std >c18, and add build files to gitignore #150

Closed scott-parkhill closed 10 months ago

scott-parkhill commented 1 year ago

Compilation was breaking using -std="c2x" because functions have been defined with implicit parameters, i.e. void foo();, and then defined as void foo(int bar), etc. Compiling on C18 works. Function declarations should be moved over to use function prototypes instead of implicit parameter declaration (obsolete since ANSI C was released in 1978).

TinoDidriksen commented 10 months ago

Already filed as https://github.com/mhulden/foma/pull/148

TinoDidriksen commented 10 months ago

Er, what? I recommend rolling back and applying #148 instead, to future-proof the code.